[Bug 49371] New: [next] rethink what features should be set on TpAutomaticClientFactory

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49371

             Bug #: 49371
           Summary: [next] rethink what features should be set on
                    TpAutomaticClientFactory
    Classification: Unclassified
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-glib
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: xclaesse at gmail.com
         QAContact: telepathy-bugs at lists.freedesktop.org


Simon mentioned for example that TP_CHANNEL_FEATURE_PASSWORD or
TP_TEXT_CHANNEL_FEATURE_CHAT_STATE shouldn't be there.

What we are missing is probably a clear definition of what we want there. Note
that it is super easy for applications to add their own features on the
factory.

Let's take TpTextChannel and TP_TEXT_CHANNEL_FEATURE_INCOMING_MESSAGES:
  I think either we think that EVERY app using a TpTextChannel surely needs
that feature and it should be marked as CORE and so will always be prepared, or
we think that some app could use TpTextChannel without it and then probably
automatic client factory shouldn't ask it neither. Note that MC should use
TpClientFactory (not the automatic) and then won't get a TpTextChannel
subclass, it it won't be a problem for it to set INCOMING_MESSAGES as CORE.

So I think we should say that factories only require CORE features, and the
question becomes: "what is CORE features?".

Another example is TP_CHANNEL_FEATURE_GROUP: should it really be CORE of
TpChannel? does MC care about preparing it? Given that it's not easy for app to
tell the features they want now, maybe we should reconsider this.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.