[Bug 30460] Generate client side API for Chan.T.ServerTLSConnection and TLSCertificate

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30460

--- Comment #18 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2012-05-03 01:21:38 PDT ---
(In reply to comment #16)
> I'd like to move the inclusion of tp_cli_* to a separate header (or even just
> only include them in the .c) so people don't start depending on them.

done.

> > +  GError *error /* badger */ ;
> 
> We should probably just get rid of that grep, it's more trouble than it's
> worth. :-(

done.

> > +      NUM_TP_TLS_CERTIFICATE_REJECT_REASONS,
> 
> I'd prefer TP_NUM_ ideally.

done.

> > +      default:
> > +        /* what does it mean? we just don't know */
> > +        self->priv->state = state;
> > +        g_object_notify ((GObject *) self, "state");
> 
> Doesn't state have a range-limited type? If so, this is invalid. :-(
> 
> We can either insist that the state is in range (and treat out-of-range values
> as invalidation with TP_DBUS_ERROR_INCONSISTENT), or remove the range-limit on
> the GObject property and let API users deal with it.
> 
> I'd be inclined to say the three states (pending, accepted, rejected) are
> exhaustive, so an out-of-range value is always a CM bug. We should put that in
> the spec really.

fixed.

(In reply to comment #17)
> (In reply to comment #15)
> > Top commit is now the GList port.
> 
> Since we don't really have any consensus on whether to go to GList or not,
> please drop that commit. Sorry.

No problem; removed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.