[Bug 49371] [next] rethink what features should be set on TpAutomaticClientFactory

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49371

--- Comment #42 from Xavier Claessens <xclaesse at gmail.com> 2012-05-10 07:04:13 PDT ---
(In reply to comment #35)
> Comment on attachment 61343 [details] [review]
> tp_channel_join/leave_async: require TP_CHANNEL_FEATURE_CONTACTS to work
> properly
> 
> Review of attachment 61343 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: telepathy-glib/channel.c
> @@ +2011,5 @@
> >  
> >    result = g_simple_async_result_new (G_OBJECT (self), callback,
> >        user_data, tp_channel_leave_async);
> >  
> > +  if (!tp_proxy_is_prepared (self, TP_CHANNEL_FEATURE_CONTACTS))
> 
> What happen if CONTACTS is prepared but channel doesn't implement Group? Looks
> like we'll use Group anyway now.

Since attachment #61340, CONTACTS fails to prepare if there is no GROUP iface.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.