[Bug 49372] deprecate tp_account/connection/channel_new

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49372

--- Comment #11 from Xavier Claessens <xclaesse at gmail.com> 2012-05-22 05:57:54 PDT ---
(In reply to comment #3)
> The commits should ideally reference this bug number (git rebase --interactive
> and use reword - I usually follow Debian's DEP-3 and use "Bug:
> https://bugs.freedesktop.org/show_bug.cgi?id=49372" as a footer in the same way
> as Signed-off-by).

Fixed by using git bz.

> In "Deprecate tp_account_parse_object_path()" you seem to have incorporated the
> switch from tp_account_ensure_connection to
> tp_simple_client_factory_ensure_connection, which should ideally have been in
> the following commit. (Not a merge blocker, obviously.)

Fixed

> > +_TP_DEPRECATED_IN_UNRELEASED
> > TpConnection *tp_account_ensure_connection (TpAccount *account,
> 
> Shouldn't this be _TP_DEPRECATED_IN_UNRELEASED_FOR
> (tp_simple_client_factory_ensure_connection)?

Fixed

> In the Automatic factory:
> > - * @dbus: a #TpDBusDaemon
> > + * @dbus: (allow-none): a #TpDBusDaemon, or %NULL
> 
> Should document the equivalence to tp_dbus_daemon_dup() like you did for the
> Simple version.

Fixed

> In tests/lib:
> > + factory = (TpSimpleClientFactory *) tp_automatic_client_factory_new (dbus);
> 
> For regression tests I think we should be using the Simple version unless
> there's a specific reason not to. (Perhaps have a nullable parameter?)

This is currently used by test-dbus-tube, because it does a
tp_simple_client_factory_ensure_channel() with connection's factory to get a
TpDBusTubeChannel. It's currently the only test doing that, because other tests
are still using the now deprecated constructors.

I think this is the right thing to do. Note that tp_connection_new() already
creates an automatic factory internally.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.