[Bug 50341] Special trick to add a contact in WLM
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Wed May 30 15:54:15 CEST 2012
https://bugs.freedesktop.org/show_bug.cgi?id=50341
--- Comment #29 from Xavier Claessens <xclaesse at gmail.com> 2012-05-30 06:54:15 PDT ---
(In reply to comment #26)
> Comment on attachment 62209 [details] [review]
> TpDynamicHandleRepo: Support async normalization function
>
> Review of attachment 62209 [details] [review]:
> -----------------------------------------------------------------
>
> ::: telepathy-glib/handle-repo-dynamic.c
> @@ +594,5 @@
> > +
> > + if (self->normalize_async == NULL)
> > + {
> > + /* Fallback to default implementation */
> > + _tp_handle_repo_default_ensure_handle_async (repo, connection, id,
>
> Do you really have to make _tp_handle_repo_default_ensure_handle_async() public
> (within the library)? Can't you chain up to something like:
>
> TP_HANDLE_REPO_IFACE_CLASS
> (tp_dynamic_handle_repo_parent_class)->ensure_handle_async()
>
> ?
I though it wasn't possible, but now I've discovered
g_type_default_interface_peek() to get the default vtable of an interface. I've
modified the code to use that and dropped that commit.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the telepathy-bugs
mailing list