[Bug 56589] Make Idle disconnect if it doesn't get a reply to its pings.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=56589

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> ---
(In reply to comment #1)
> + if (seconds_since_ping > priv->keepalive_interval *
> MISSED_KEEPALIVES_BEFORE_DISCONNECTING) {
> 
> I personally love as many brackets as possible to make everything clear.

I think
http://cgit.freedesktop.org/telepathy/telepathy-idle/commit/?id=c679fe4baaec1c29f7d0fbbed1f6b1d9c7d1266c
may be clearer, too?

> Otherwise looks great! What a nice easy branch to review, thanks!

Consider it merged:
http://cgit.freedesktop.org/telepathy/telepathy-idle/commit/?id=27c1ffc5ebcfcb37ad958ef451ca2772bdc4ec01

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.