[Bug 54780] McpAccountStorage::altered-one basically only works for parameters

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Nov 7 18:30:50 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=54780

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> ---
In commit 05d1af087:

@@ -514,10 +520,17 @@ mcp_account_storage_priority (const McpAccountStorage
*storage)
  *  like "DisplayName", or "param-" plus a parameter like "account"
  *
  * Get a value from the plugin's in-memory cache.
- * The plugin is expected to call mcp_account_manager_set_value(),
- * and if appropriate, mcp_account_manager_parameter_make_secret(),
+ * The plugin is expected to call
+ * Before emitting this signal, the plugin must call
+ * either mcp_account_manager_set_attribute(),
+ * mcp_account_manager_set_parameter(),
+ * or mcp_account_manager_set_value() and (if appropriate)
+ * mcp_account_manager_parameter_make_secret()
  * before returning from this method call.

There's a stray “The plugin is expected to call” in there.

It otherwise looks fine.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the telepathy-bugs mailing list