[Bug 57016] New: Make wocky_stanza_get_type_info() check namespaces

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Nov 12 15:28:27 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=57016

          Priority: medium
            Bug ID: 57016
          Keywords: patch
          Assignee: telepathy-bugs at lists.freedesktop.org
           Summary: Make wocky_stanza_get_type_info() check namespaces
        QA Contact: telepathy-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: will.thompson at collabora.co.uk
               URL: http://cgit.collabora.com/git/user/wjt/wocky/log/?h=st
                    anza-types
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: General
           Product: Wocky

Previously, wocky_stanza_get_type_info() did not check the namespace of the
stanza's top node. So it claimed that this:

  <challenge xmlns='l:o:l'/>

has type WOCKY_STANZA_TYPE_CHALLENGE, which is not the case: it should look
like this:

  <challenge xmlns='urn:ietf:params:xml:ns:xmpp-sasl'/>

Ditto all other stanza types. As it happens, there are no name collisions so it
works out fine.

Here's a branch which fixes this. It also adds a new property to
WockyXmppReader which lets you specify a default namespace when it's in
non-streaming mode. This makes life easier for Gabble's console plugin, as seen
in the corresponding branch to update Gabble:
<http://cgit.collabora.com/git/user/wjt/telepathy-gabble/log/?h=console-stanza-namespace>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list