[Bug 49633] Haze accounts loses sync with Gnome-Shell

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49633

--- Comment #12 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 70028
  --> https://bugs.freedesktop.org/attachment.cgi?id=70028
Increase timeout

Review of attachment 70028:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=49633&attachment=70028)
-----------------------------------------------------------------

There are more instances of calls to introspect a client: I feel as though if
we extend one, we should extend them all. (We shouldn't extend the timeout when
we call HandleChannels or similar, though.)

In _mcd_client_proxy_get_interfaces_cb we call Get or GetAll 3 times.

In mcd_client_proxy_introspect there is a call to GetAll.

::: telepathy-mission-control-5-5.12.1/debian/patches/path_cassidy.patch
@@ +4,5 @@
> + 
> +         _mcd_client_proxy_inc_ready_lock (self);
> + 
> +-        tp_cli_dbus_properties_call_get (self, -1,
> ++        tp_cli_dbus_properties_call_get (self, G_MAXINT,

Strictly speaking, the infinite timeout is G_MAXINT32 (although they're
numerically the same on any sane platform).

I'd prefer to use the named constant to make the meaning obvious:

#include <dbus/dbus.h>

#ifndef DBUS_TIMEOUT_INFINITE
/* dbus < 1.4.12 didn't have this */
# define DBUS_TIMEOUT_INFINITE G_MAXINT32
#endif

...

tp_cli_dbus_properties_call_get (self, DBUS_TIMEOUT_INFINITE, ...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.