[Bug 57016] Make wocky_stanza_get_type_info() check namespaces

Wed Nov 14 19:21:28 CET 2012

https://bugs.freedesktop.org/show_bug.cgi?id=57016

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> ---
(In reply to comment #1)
> This comment in the diff context is no longer entirely true:
> 
> # Wocky fills in xmlns='' for us if we don't specify a namespace... great.
> # So this means <message/> gets sent as <message xmlns=''/> and the server
> # kicks us off.
> 
> All looks good though - ship it, and fix that comment if you're feeling
> virtuous.
> 
> > In the course of fixing this, I found that telling the console to send
> > this: <message> <body> hai </body> </message>
> > would send this: <message xmlns='jabber:client'> <body xmlns=''>
> 
> ... which we presumably never noticed, because it worked fine in practice on
> typical XMPP clients. Namespaces? We've heard of them (where "we" means
> "XMPP implementors in general")

Yeah. Gabble doesn't care, for instance. (Also, I find the console most useful
for sending IQs, whose bodies always have an explicit namespace, so the issue
of recursively fixing up the ns never came up!)

Merged to Wocky and Gabble master:

http://cgit.freedesktop.org/wocky/log/?id=31f33f4ba66bcdddda84b419cf4960073d071290

http://cgit.freedesktop.org/telepathy/telepathy-gabble/commit/?id=1d6c3044f13488e5457a31be631dec8e12068b6b

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.