[Bug 33789] finalising Jingle session too early causes error for unknown session

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33789

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |will.thompson at collabora.co.
                   |                            |uk

--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk> ---
        * unknown-session xmlns='urn:xmpp:jingle:errors:1'

This is actually defined by <http://xmpp.org/extensions/xep-0166.html#errors>
to mean:

> The 'sid' attribute specifies a session that is unknown to the recipient
> (e.g., no longer live according to the recipient's state machine because
> the recipient previously terminated the session).

<http://xmpp.org/extensions/xep-0166.html#session-terminate> goes so far as to
say:

> Note: As soon as an entity sends a session-terminate action, it MUST
> consider the session to be in the ENDED state (even before receiving
> acknowledgement from the other party). If the terminating entity receives
> additional Jingle-related IQ-sets from the other party after sending the
> session-terminate action, it MUST reply with an <unknown-session/> error.

so this error is actually required by the spec!

But I wrote a quick test for it and found that I broke this last March.
Gabble's been sending <gone> instead since then. I pushed a fix and the test to
master.
http://cgit.freedesktop.org/telepathy/telepathy-gabble/commit/?id=ecee60dfc

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.