[Bug 57603] New: Clean up reimplemented xml node manipulation in vcard-manager

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=57603

          Priority: medium
            Bug ID: 57603
          Keywords: patch
          Assignee: telepathy-bugs at lists.freedesktop.org
           Summary: Clean up reimplemented xml node manipulation in
                    vcard-manager
        QA Contact: telepathy-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: will.thompson at collabora.co.uk
          Hardware: Other
            Status: NEW
           Version: git master
         Component: gabble
           Product: Telepathy

I found myself looking at the vcard manager code, and noticed that it contains
not one, but two reimplementations of recursively copying a tree of elements,
as well as its own home-grown implementation of a (shallow) node tree.

With a couple of additions to the WockyNode API (one of which actually isn't
used by the end of my Gabble branch, but there we go), we can cut out a hundred
or so lines of code from vcard-manager.c and make it much easier to follow in
the process.

http://cgit.collabora.com/git/user/wjt/wocky/log/?h=node-stuff
http://cgit.collabora.com/git/user/wjt/telepathy-gabble/log/?h=vcard-manager-use-nodes

will be the branches when that server comes back to life.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.