[Bug 55539] New: Searching Pidgin log store matches search against tags

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55539

          Priority: medium
            Bug ID: 55539
          Assignee: telepathy-bugs at lists.freedesktop.org
           Summary: Searching Pidgin log store matches search against tags
        QA Contact: telepathy-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: will.thompson at collabora.co.uk
          Hardware: Other
            Status: NEW
           Version: git master
         Component: logger
           Product: Telepathy

Created attachment 67992
  --> https://bugs.freedesktop.org/attachment.cgi?id=67992&action=edit
demonstrates this bug in the pidgin log store

The Pidgin log store searches by just matching the query against mmaped log
files using strstr().
http://cgit.freedesktop.org/telepathy/telepathy-logger/tree/telepathy-logger/log-store-pidgin.c#n901

This is great, except that it matches the names of tags as well as the contents
of your messages. See the attached patch, which changes the test suite to
search for "font". The only occurrence of "font" in the test suite's pidgin
logs is as "<font …>" or "</font>", so it shouldn't match, but does.

The XML log store doesn't have this bug. It searches your logs with … a regex …
to match XML. Which I suppose works, but…
http://cgit.freedesktop.org/telepathy/telepathy-logger/tree/telepathy-logger/log-store-xml.c#n1550

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.