[Bug 55668] New: use the self-contact to handle Aliasing

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55668

          Priority: medium
            Bug ID: 55668
          Keywords: patch
                CC: jonny.lamb at collabora.co.uk, xclaesse at gmail.com
          Assignee: simon.mcvittie at collabora.co.uk
           Summary: use the self-contact to handle Aliasing
        QA Contact: telepathy-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: simon.mcvittie at collabora.co.uk
               URL: http://cgit.freedesktop.org/~smcv/telepathy-mission-co
                    ntrol/log/?h=we-have-a-self-contact
          Hardware: Other
            Status: ASSIGNED
           Version: unspecified
         Component: mission-control
        Depends on: 55391
           Product: Telepathy

+++ This bug was initially created as a clone of Bug #55391 +++

On that bug, I wrote:

> Other things to do include:
> 
> McdConnection has quite a lot of tp_connection_get_self_handle(). The
> simple fix would be to copy that function's implementation every time
> we call it - but it would be better if we used a TpContact for the
> self-contact, attached it to the McdAccount instead of the McdConnection,
> and used high-level APIs instead. This should be done separately for
> aliasing, presence, avatars, and any other offending interfaces.

Let's do Aliasing first. It turns out to be a small net code-deletion:

 src/mcd-account.c         |  183 ++++++++++++++++++++++++++++++++++++++-------
 src/mcd-connection-priv.h |    3 -
 src/mcd-connection.c      |  147 ------------------------------------
 3 files changed, 157 insertions(+), 176 deletions(-)

(when tests are ignored)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.