[Bug 55666] only monitors SelfHandleChanged if the CM is obsolete

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Oct 8 11:57:20 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=55666

--- Comment #10 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #8)
> Do we need those g_debug(), and shouldn't them be DEBUG()?

1) Not really, I've deleted them.

2) If I'd kept them: yes, I should have #include'd "tests/lib/debug.h" (not
that we use it very consistently).

(In reply to comment #9)
> tbh, I don't understand why we do both internal and non-internal libs for
> tests? Why can't all tests just link to tp-glib's internal by default?

Linking tests against the shared library means we're testing the same binary
that library users use, which is after all what we wanted to achieve; it's also
good for efforts like Debian's DEP-8, which run tests in the installed system.

I might turn _tp_dbus_properties_mixin_get_all() into public API on 0.21, at
which point this test can go back to being linked to the shared library. Any
objection?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.



More information about the telepathy-bugs mailing list