[Bug 55391] stop MC using things deprecated in 0.20

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55391

--- Comment #31 from Xavier Claessens <xclaesse at gmail.com> ---
(In reply to comment #30)
> Comment on attachment 67797 [details] [review]
> _mcd_channel_depart: use tp_channel_leave_async if  it's a Group
> 
> Review of attachment 67797 [details] [review]:
> -----------------------------------------------------------------
> 
> I think it is handler's responsability to do clean group leave. If MC has to
> close the channel, it can be an abrupt Close(), no? I don't want MC to start
> preparing GROUP feature if we didn't have to so far. GROUP won't be core in
> next and will prepare all TpContact objects. So I think there is something
> wrong to start creating potentially thousands of TpContact just to actually
> QUIT that channel...
> 
> ::: src/mcd-channel.c
> @@ +1214,5 @@
> >      d->message = g_strdup (message);
> >  
> > +    /* tp_channel_leave_async documents calling it without first preparing
> > +     * GROUP as deprecated. */
> > +    tp_proxy_prepare_async (channel->priv->tp_chan, just_group_feature,
> 
> The reason why I've made that behaviour deprecated is because it is not when
> you leave the channel that you want to start preparing more stuff. GROUP
> won't be CORE in next and will involve prepare all members TpContact...
> 
> Shouldn't MC just Close() in the case the client did not properly leave?

Argh, seems I drafted that reply previously and bugzilla included both... Bah
you get the idea :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.