[Bug 55391] stop MC using things deprecated in 0.20

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Oct 8 16:46:56 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=55391

--- Comment #38 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #26)
> ::: src/mcd-account.c
> @@ +2392,5 @@
> >  
> >      callback (account, error, user_data);
> >      g_clear_error (&error);
> > +    g_list_free_full (params,
> > +                      (GDestroyNotify) tp_connection_manager_param_free);
> 
> We do 4 spaces indent in this case nowadays. But I can accept if you say the
> coding style is broken everywhere in that file anyway :)

I ignored this; the prevailing coding style in MC is unlike ordinary Telepathy
style anyway (it's more like Qt/Java style than GNU style) so, yeah.

In recent MC branches I've changed my policy from "new files get ordinary
Telepathy style" to "new *functions* usually get ordinary Telepathy style" in
an attempt to reach Telepathy style eventually, but I don't think mass
reindentation is going to make merging between master and next any easier.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.



More information about the telepathy-bugs mailing list