[Bug 55668] use the self-contact to handle Aliasing and Avatars

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55668

--- Comment #13 from Xavier Claessens <xclaesse at gmail.com> ---
Comment on attachment 68127
  --> https://bugs.freedesktop.org/attachment.cgi?id=68127
McdAccount: take responsibility for setting the nickname

Review of attachment 68127:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=55668&attachment=68127)
-----------------------------------------------------------------

::: src/mcd-account.c
@@ +1318,5 @@
> +    gpointer user_data,
> +    GObject *weak_object)
> +{
> +  if (error)
> +    WARNING ("%s", error->message);

Do we want a warning here? We usually uses DEBUG() for failing dbus calls

@@ +4546,5 @@
> +      if (self_contact == self->priv->self_contact)
> +        {
> +          tp_g_signal_connect_object (self_contact, "notify::alias",
> +              G_CALLBACK (mcd_account_self_contact_notify_alias_cb),
> +              self, G_CONNECT_SWAPPED);

swapped is nice to avoid the GParamSpec useless arg, but in this case you use
both self and self_contact, so swapped is not needed.

@@ +4560,5 @@
> +      g_ptr_array_unref (contacts);
> +    }
> +  else
> +    {
> +      WARNING ("failed to prepare self-contact: %s", error->message);

Same here, should we downgrade to DEBUG?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.