[Bug 55668] use the self-contact to handle Aliasing and Avatars

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55668

--- Comment #15 from Xavier Claessens <xclaesse at gmail.com> ---
Comment on attachment 68131
  --> https://bugs.freedesktop.org/attachment.cgi?id=68131
McdAccount: cope with self-contact changes; follow the  self-contact

Review of attachment 68131:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=55668&attachment=68131)
-----------------------------------------------------------------

::: src/mcd-account.c
@@ +4590,5 @@
> +  if (self_contact != self->priv->self_contact)
> +    {
> +      g_clear_object (&self->priv->self_contact);
> +      self->priv->self_contact = g_object_ref (self_contact);
> +    }

I would early return if self->priv->self_contact == self_contact, this would
avoid useless extra work.

@@ +4631,5 @@
>                                          tp_connection, dbus_error, details);
>  
> +    tp_g_signal_connect_object (tp_connection, "notify::self-contact",
> +        G_CALLBACK (mcd_account_self_contact_changed_cb), account,
> +        G_CONNECT_SWAPPED);

swapped is not useful here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.