[Bug 55668] use the self-contact to handle Aliasing and Avatars

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55668

--- Comment #17 from Xavier Claessens <xclaesse at gmail.com> ---
Comment on attachment 68137
  --> https://bugs.freedesktop.org/attachment.cgi?id=68137
Track Avatars using McdAccount, and use the self-contact  for it

Review of attachment 68137:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=55668&attachment=68137)
-----------------------------------------------------------------

::: src/mcd-account.c
@@ +1382,5 @@
> +static void
> +mcd_account_self_contact_notify_avatar_file_cb (McdAccount *self,
> +    GParamSpec *unused_param_spec G_GNUC_UNUSED,
> +    TpContact *self_contact)
> +{

Actually you don't need the unused_param_spec and self_contact args, which is
the point of connect_swapped.

@@ +1429,5 @@
> +          g_free (uri);
> +          return;
> +        }
> +
> +      if (G_UNLIKELY (len > G_MAXUINT))

You're probably already OOM-killed at this point, but ok :)

@@ +4769,5 @@
> +
> +          tp_g_signal_connect_object (self_contact, "notify::avatar-file",
> +              G_CALLBACK (mcd_account_self_contact_notify_avatar_file_cb),
> +              self, G_CONNECT_SWAPPED);
> +          mcd_account_process_initial_avatar_token (self, self_contact);

You don't need that self_contact arg, it is self->priv->self_contact

-- 
You are receiving this mail because:
You are the QA Contact for the bug.