[Bug 55668] use the self-contact to handle Aliasing and Avatars

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55668

--- Comment #19 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #18)
> > Wondering what happens if I set my nickname to empty string. Won't
> > "notify::alias" be emitted to normalized id, and then
> > mcd_account_self_contact_notify_alias_cb() will set normalized id as account
> > nickname?
> 
> Yes. I think that's probably a feature - setting an empty nickname makes so
> little sense that I think we should quietly "correct" it.

mcd_account_set_string_val() "normalizes" an empty string to NULL anyway, so
using tp_str_empty() here wasn't actually a behaviour change.

When we connect, if we have no nickname stored locally, I think it's correct to
try to get it from the remote connection - this means we do the right thing
when creating e.g. a Gabble account and not specifically setting a nickname
(we'll get the one from the server).

I think it makes sense to standardize on "nickname of '' is bad, try to do
something better". I'll append a patch to make Set("Nickname", "") use the
normalized name too.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.