[Bug 37844] Don't try to reconnect an account over and over for certain errors

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37844

--- Comment #12 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 48038
  --> https://bugs.freedesktop.org/attachment.cgi?id=48038
Check for the specific error codes when reconnecting

Review of attachment 48038:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=37844&attachment=48038)
-----------------------------------------------------------------

::: src/mcd-connection.c
@@ +1236,5 @@
> +            return FALSE;
> +
> +        default:
> +            DEBUG ("TpError code %s not handled",
> +                tp_error_get_dbus_name (code));

REGISTRATION_EXISTS, WOULD_BREAK_ANONYMITY, CAPTCHA_NOT_SUPPORTED should also
specifically not reconnect (although as implemented here, they probably won't
anyway).

RESOURCE_UNAVAILABLE I'm not sure about. Any opinions?

The remaining unhandled cases are

NOT_IMPLEMENTED
NOT_AVAILABLE
CONFUSED
SERVICE_CONFUSED

which are too vague to make any particular decision, and

PERMISSION_DENIED
CHANNEL_*
NOT_YOURS
NOT_CAPABLE
OFFLINE
BUSY
NO_ANSWER
DOES_NOT_EXIST
TERMINATED
NOT_YET
REJECTED
PICKED_UP_ELSEWHERE
EMERGENCY_CALLS_NOT_SUPPORTED
INSUFFICIENT_BALANCE
MEDIA_*

which don't make sense in this context.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.