[Bug 55883] ClientTypes list is not updated when contact goes offline

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55883

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Here is a regression test for Gabble if anyone wants to work on this. I had a
quick look, but the presence/presence-cache code is a bit tangled.

diff --git a/tests/twisted/client-types.py b/tests/twisted/client-types.py
index 2eaeebe..62ea62e 100644
--- a/tests/twisted/client-types.py
+++ b/tests/twisted/client-types.py
@@ -241,6 +241,13 @@ def test2(q, bus, conn, stream):
     assertContains(attr, attrs[handle])
     assertEquals(['pc'], attrs[handle][attr])

+    # both devices go offline
+    stream.send(make_presence(marco_pidgin, type='unavailable'))
+    q.expect('dbus-signal', signal='ClientTypesUpdated',
+             args=[handle, ['phone']])
+    stream.send(make_presence(marco_phone, type='unavailable'))
+    q.expect('dbus-signal', signal='ClientTypesUpdated', args=[handle, []])
+
 def two_contacts_with_the_same_hash(q, bus, conn, stream, bare_jids):
     contact1 = 'bowyer.place at tfl.gov.uk'
     contact2 = 'albany.road at tfl.gov.uk'

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.