[Bug 56600] Connman API changed

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=56600

--- Comment #1 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
Comment on attachment 69339
  --> https://bugs.freedesktop.org/attachment.cgi?id=69339
Update Connman API usage

Review of attachment 69339:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=56600&attachment=69339)
-----------------------------------------------------------------

Please attach a proper git commit (git format-patch) so I can review the commit
message as well.

The fact that you didn't have to change fakeconnectivity.py indicates that this
code is poorly tested. Any chance to extend the test?

::: src/connectivity-monitor.c
@@ +194,2 @@
>      {
> +      if (g_hash_table_lookup_extended (props, "State", NULL, &val))

Couldn't you use tp_asv_get_string().

@@ +301,4 @@
>            "net.connman.Manager");
>  
>        dbus_g_object_register_marshaller (
> +          g_cclosure_marshal_generic,

Smcv: is it ok to use the generic marshaller here? The _mcd_ext_marshal_* don't
seem to be used any more.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.