[Bug 39189] [next] decide on a policy for transfer, naming and containers

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39189

--- Comment #17 from Xavier Claessens <xclaesse at gmail.com> 2012-09-04 08:58:07 UTC ---
(In reply to comment #15)
> There are 7 functions returning GList with "transfer container":
> 
> tp_account_manager_get_valid_accounts()
> tp_base_client_get_pending_requests()
> tp_base_client_get_handled_channels()
> tp_connection_get_contact_info_supported_fields()
> tp_contact_search_result_get_fields()
> tp_contact_get_contact_info()
> tp_text_channel_get_pending_messages()
> 
> Note that I've grepped "transfer container" so probably missing not/wrongly
> annotated CM-side APIs.

Made a more extensive audit of our code and I confirm those are the only
getters that returns GList with transfer-container. Note that I've found some
getters that returns GList with transfer-none:

tp_base_call_channel_get_contents
tp_base_call_content_get_streams
tp_base_media_call_stream_get_endpoints

So current situation isn't consistent at all. So I'll prepare patch to
deprecate transfer-container getters and add corresponding dup with
transfer-full.

Any objection?

--- Comment #18 from Xavier Claessens <xclaesse at gmail.com> 2012-09-04 09:00:41 UTC ---
(In reply to comment #15)
> There are 7 functions returning GList with "transfer container":
> 
> tp_account_manager_get_valid_accounts()
> tp_base_client_get_pending_requests()
> tp_base_client_get_handled_channels()
> tp_connection_get_contact_info_supported_fields()
> tp_contact_search_result_get_fields()
> tp_contact_get_contact_info()
> tp_text_channel_get_pending_messages()
> 
> Note that I've grepped "transfer container" so probably missing not/wrongly
> annotated CM-side APIs.

Made a more extensive audit of our code and I confirm those are the only
getters that returns GList with transfer-container. Note that I've found some
getters that returns GList with transfer-none:

tp_base_call_channel_get_contents
tp_base_call_content_get_streams
tp_base_media_call_stream_get_endpoints

So current situation isn't consistent at all. So I'll prepare patch to
deprecate transfer-container getters and add corresponding dup with
transfer-full.

Any objection?

--- Comment #19 from Xavier Claessens <xclaesse at gmail.com> 2012-09-04 10:57:57 UTC ---
oh, and to add to the policy: _finish() functions dups the return values and
out args. I remember having seen an exception to that rule, but couldn't find
which function anymore. Could be in another codebase (empathy?).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.