[Bug 54495] New: Eavesdropping on replies can sometimes break the tests
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Tue Sep 4 18:15:48 CEST 2012
https://bugs.freedesktop.org/show_bug.cgi?id=54495
Bug #: 54495
Summary: Eavesdropping on replies can sometimes break the tests
Classification: Unclassified
Product: Telepathy
Version: unspecified
Platform: Other
OS/Version: All
Status: ASSIGNED
Keywords: patch
Severity: normal
Priority: medium
Component: mission-control
AssignedTo: simon.mcvittie at collabora.co.uk
ReportedBy: simon.mcvittie at collabora.co.uk
QAContact: telepathy-bugs at lists.freedesktop.org
CC: jonny.lamb at collabora.co.uk
Created attachment 66610
--> https://bugs.freedesktop.org/attachment.cgi?id=66610
servicetest: don't eavesdrop on method replies or errors
Eavesdropping on method replies breaks libdbus if you call methods using the
same connection. You can get into a situation like this:
* Test calls a method on MC; say the serial number is 42
* At around the same time, MC calls a method on gnome-keyring and also uses
serial number 42
* gnome-keyring replies, labelled "in reply to 42"
* Test is eavesdropping, so it sees the reply going from gnome-keyring to MC
* Test interprets the reply from gnome-keyring to MC as the reply it was
expecting from MC, sees completely the wrong types, and becomes
confused
This seems unlikely - but because serial numbers are sequential and
start from 1 for each connection (as opposed to starting from a random
offset), two connections can quite easily happen to sync up. I saw it
happen most recently in the gnome-keyring test. With the benefit
of hindsight, I think I've seen this before: whenever the tests
made an Introspect() call which returned a type other than 's', that
was probably this bug.
We never actually generated events for messages other than signals and
method calls, so match those ones specifically, and don't eavesdrop on
replies.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
More information about the telepathy-bugs
mailing list