[Bug 54539] Storage plugins should be able to request a reconnection

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=54539

--- Comment #3 from Xavier Claessens <xclaesse at gmail.com> 2012-09-05 10:49:28 UTC ---
(In reply to comment #2)
> > + return iface->reconnect (mcpa, account);
> 
> "return x()", where x is a void function, is rejected by some C compilers.
> Remove "return".

stupid mistake, wondering why my gcc is happy with it... Fixed.

> I'm not sure what our rule of thumb is for whether a storage plugin should emit
> a signal, or whether it should call a method on the McpAccountManager. This
> feels intuitively like a job for a signal to me, but I can't quite articulate
> why...
> 
> It does occur to me that if the storage plugin emitted a signal, it could be
> caught by the McdAccountManager (which already has to listen for ::created,
> ::altered, etc. anyway) and there wouldn't be any need for additional
> boilerplate in McdStorage, which would be nice.
> 
> (If you go the signal route, it might be nice to add a
> mcp_account_storage_emit_reconnect() that the plugin can call, so it doesn't
> need to mess about with g_signal_emit_by_name().)

Indeed that's seems easier like that. I was lost in all those ifaces/objects :(


Branch updated.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.