[Bug 54780] New: McpAccountStorage::altered-one basically only works for parameters

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Sep 11 17:09:24 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=54780

             Bug #: 54780
           Summary: McpAccountStorage::altered-one basically only works
                    for parameters
    Classification: Unclassified
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: mission-control
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: simon.mcvittie at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org
                CC: guillaume.desmottes at collabora.co.uk,
                    simon.mcvittie at collabora.co.uk, xclaesse at gmail.com


Based on my testing, when McpAccountStorage::altered-one is emitted, it doesn't
actually work for most account properties.

This is because mcd_account_property_changed() (renamed to
mcd_account_altered_by_plugin() in one of my branches) tries to copy things
from internal storage to D-Bus by calling getprop() followed by setprop(). As
far as I can tell, the intention is that this retrieves the new value from
McdStorage (where it was previously left by mcp_account_manager_set_value()),
then saves it again. Unfortunately, most getprop() implementations work from
the McdAccount's internal data structure, so they never see the new value...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list