[Bug 54879] [next] initial 'next' branch

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=54879

--- Comment #7 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-09-13 16:45:02 UTC ---
In "service-point: stop using deprecated APIs and add a small test"

+              g_print ("adding %s to the string list\n", *ptr);

I think you left your debugging code in.

I think the complexity of this patch is an indication that Conn.I.ServicePoint
should change like this on next:

Service_Point: (us) type, ID -> (uus) type, handle, ID

Service_Point_Info: ((us)as) type, ID, aliases -> ((uus)a{su}) or something

I've only skim-read the patch, but it looks basically sensible, and the fact
that you add a test is a good sign.

+# MC used to critical if more than one emergency service point was
+# given by the CM. That's silly, so let's test it.

Almost as if this had never been tested...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.