[Bug 54917] Should have GVariant helpers similar to tp_asv_

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=54917

--- Comment #1 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2012-09-14 12:43:51 UTC ---
http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/commit/?h=variant&id=cb2fbab3b4079843e240035ebbf7c4f318e36f06

 * These functions provide convenient access to the values in such
+ * a mapping.

"in such mapping" ?

+ * Since: 0.UNRELEASED

These API are not new so maybe we should remove this.

http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/commit/?h=variant&id=ca47ad360751210e016632bbc8a8e50bc4aaace8

+GVariantClass
+tp_variant_type_classify (const GVariantType *type)
+{
+  return *g_variant_type_peek_string (type);

This is worth a comment and I'd use [0] (easier to understand).

+
+  switch (g_variant_classify (variant))
+    {
+    case G_VARIANT_CLASS_DOUBLE:

'case' should be idented.

Same for the others switch.

http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/commit/?h=variant&id=c6dc12c3f6b64eb5f526ccf775df5b399ec1d4a7

Can't you link on the internal lib and use _tp_asv_to_vardict() ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.