[Bug 14540] Names interface - Aliasing replacement with separate nickname, local alias etc.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=14540

--- Comment #30 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-09-17 10:08:39 UTC ---
(In reply to comment #29)
> Actually mixins are a mess:
> 1) TpBaseContactList: must be subclassed

It's primarily an object, not a mixin, because that's how we've traditionally
done the contact list (and in master it had to be a TpChannelManager for
historical reasons[1]; in next it doesn't really need to be).

> 2) TpPresenceMixin: no interface but a TpPresenceMixinClass to include in class
> struct.

My concern about this approach is that it's probably pessimal for
gobject-introspection - not that we're introspectable on the CM side at the
moment anyway, but we'd like to be one day.

> 3) TpAvatarsMixin: no interface and no class struct, virtual methods are in
> instance's private.

This seems wrong conceptually, if for no other reason: methods are a property
of the class, not the instance.

> 5) TpGroupMixin: like TpPresenceMixin, but the class struct does not have
> padding for future extension but it has a private struct (that is leaked, btw)

Bugs/patches welcome :-)

[1] ContactList, ContactGroup channels

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.