[Bug 55338] Miscellaneous clean-up of the TplLogStore API

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Sep 27 13:28:35 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=55338

--- Comment #1 from Jonny Lamb <jonny.lamb at collabora.co.uk> ---
"Correct some typos in docstrings":

  * If an TplLogStore implementation is writable, the #TplLogManager will call
- * it's tpl_log_store_add_event() method every time a loggable even occurs,
- * i.e., everytime _tpl_log_manager_add_event() is called.
+ * its tpl_log_store_add_event() method every time a loggable even occurs,
+ * i.e., every time _tpl_log_manager_add_event() is called.

Interesting you fixed these typos but missed "an TplLogStore" and "a loggable
even"!

- g_value_set_string (value, priv->name);
+ g_value_set_string (value, TPL_LOG_STORE_PIDGIN_NAME);

You could use _set_static_string here if you wanted? Oh you remove the property
later. Never mind then.

Your changes look fine to me.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list