[Bug 55392] New: _mcd_channel_depart doesn't Close() channels that turn out not to be a Group

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55392

          Priority: medium
            Bug ID: 55392
                CC: jonny.lamb at collabora.co.uk, xclaesse at gmail.com
          Assignee: simon.mcvittie at collabora.co.uk
            Blocks: 55391
           Summary: _mcd_channel_depart doesn't Close() channels that turn
                    out not to be a Group
        QA Contact: telepathy-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: simon.mcvittie at collabora.co.uk
          Hardware: Other
            Status: ASSIGNED
           Version: unspecified
         Component: mission-control
           Product: Telepathy

Pseudocode for how _mcd_channel_depart() should work:

    if we know whether it's a Group already:
        if it is:
            try:
                leave
            except:
                close
        else:
            close
    else:
        find out
        if it is:
            try:
                leave
            except:
                close
        else:            # <--
            close        # <--

(where, in all cases, "close" ignores errors).

In fact, the last two lines are missing. If we didn't already know whether it
was a Group, but it turns out not to be, we don't close it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.