[Bug 55391] stop MC using things deprecated in 0.20
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Thu Sep 27 20:01:06 CEST 2012
https://bugs.freedesktop.org/show_bug.cgi?id=55391
--- Comment #21 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
That's all for now. Those patches are not enough to be able to turn on fatal
deprecation warnings for 0.20 yet, but they're heading that way.
This is firmly in 5.15 territory: too much churn for (what's about to be) a
stable branch.
Other things to do include:
McdConnection has quite a lot of tp_connection_get_self_handle(). The simple
fix would be to copy that function's implementation every time we call it - but
it would be better if we used a TpContact for the self-contact, attached it to
the McdAccount instead of the McdConnection, and used high-level APIs instead.
This should be done separately for aliasing, presence, avatars, and any other
offending interfaces.
When we've done them all, that'll be several fewer things between here and
deleting McdConnection altogether. (I don't like McdConnection - it and
McdAccount have lots of circular dependencies, and its life-cycle is pretty
weird, since the same one is used across multiple attempts to reconnect after
an error, but deliberate disconnection does kill it off. Make your mind up...)
Elsewhere, there's the emergency call stuff that Jonny looked at in next (use
of deprecated functions + lack of a regression test + not actually working). I
hoped that we could just delete it because it only affected mcd_* APIs that can
no longer be called from out-of-tree, but in fact it does affect MC's
behaviour: plugins aren't given the opportunity to reject or delay outgoing
emergency calls.
However, it's debatable how useful this is, given that plugins have to be 100%
trusted anyway (they share our address space) and in any case, I don't think it
would need to map IDs to handles at all if we just documented that if you make
an emergency call and want it to get this special treatment, you must do so by
putting TargetID and/or InitialServicePoint in the request.
--
You are receiving this mail because:
You are the QA Contact for the bug.
More information about the telepathy-bugs
mailing list