[Bug 55394] New: Three test cases #include the .c file they're testing!

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55394

          Priority: medium
            Bug ID: 55394
          Keywords: patch
          Assignee: telepathy-bugs at lists.freedesktop.org
           Summary: Three test cases #include the .c file they're testing!
        QA Contact: telepathy-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: will.thompson at collabora.co.uk
               URL: http://cgit.collabora.com/git/user/wjt/telepathy-logge
                    r/commit/?h=dont-import-c-files-in-tests
          Hardware: Other
            Status: NEW
           Version: git master
         Component: logger
           Product: Telepathy

I was pretty surprised to find this.

I didn't mention this in the patch, but I particularly enjoyed how all these
tests were redefining DEBUG_FLAG /after/ including -debug-internal.h, which is
too late: the DEBUG macro has already been defined.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.