[Bug 66085] Turn XMPP console sidecar into a channel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=66085

--- Comment #3 from Will Thompson <will at willthompson.co.uk> ---
(In reply to comment #1)
> + /* Not reffing this: the connection owns all channel managers, so it
> + * must outlive us. Taking a reference leads to a cycle.
> + */
> + self->plugin_connection = g_value_get_object (value);
> 
> Weak ref, or drop it on DISCONNECTED state?

Pushed b88fa16  which makes it use a weak ref.

> +gabble_console_channel_manager_dispose (
> + GObject *object)
> +{
> + GabbleConsoleChannelManager *self = GABBLE_CONSOLE_CHANNEL_MANAGER
> (object);
> + TpBaseChannel *channel;
> +
> + while ((channel = g_queue_peek_head (&self->console_channels)) != NULL)
> + {
> + tp_base_channel_close (channel);
> 
> _destroy instead? (Not that it really matters for these particular channels.)

There's no such method. (tp_base_channel_destroyed() is to be used by the
subclass itself.)

> + # We only prepare the channel so that ::invalidated will be emitted
> + # when it closes.
> 
> Is this really necessary? I would expect that channels would invalidate
> anyway.

You're right. Pushed 37eef77 which does away with that.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.