[Bug 68712] New: connectivity code is far too complicated

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=68712

          Priority: medium
            Bug ID: 68712
          Assignee: simon.mcvittie at collabora.co.uk
           Summary: connectivity code is far too complicated
        QA Contact: telepathy-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: simon.mcvittie at collabora.co.uk
          Hardware: Other
            Status: ASSIGNED
           Version: git master
         Component: mission-control
        Depends on: 56635
           Product: Telepathy

In theory, Mission Control used to support multiple connectivity backends with
pluggability and and and. (In practice, I don't think it ever worked.)

Now that I have a branch (Bug #56635) to use GNetworkMonitor (which is also
pluggable), it seems like a good time to cut the complexity:

 src/Makefile.am              |   7 +-
 src/connectivity-monitor.c   |  21 ++-
 src/kludge-transport.c       | 268 --------------------------------
 src/kludge-transport.h       |  61 --------
 src/mcd-account-connection.c |  70 ++++-----
 src/mcd-account-manager.c    |  23 ++-
 src/mcd-account-manager.h    |   4 +
 src/mcd-account-priv.h       |   3 -
 src/mcd-account.c            | 175 +++++++++++++--------
 src/mcd-account.h            |  15 +-
 src/mcd-channel.c            |   1 -
 src/mcd-channel.h            |   7 -
 src/mcd-connection-plugin.h  |  50 ------
 src/mcd-dispatcher.h         |  15 --
 src/mcd-manager.h            |   6 -
 src/mcd-master-priv.h        |   6 -
 src/mcd-master.c             | 361 ++-----------------------------------------
 src/mcd-master.h             |  23 +--
 src/mcd-operation.c          |  39 ++---
 src/mcd-transport.c          | 188 ----------------------
 src/mcd-transport.h          |  83 ----------
 21 files changed, 231 insertions(+), 1195 deletions(-)

(Admittedly, that figure includes some other refactoring on the way.)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.