[Bug 35548] Porter: _close_async() should take a timeout, and _force_close_async() should not be API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35548

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |will.thompson at collabora.co.
                   |                            |uk

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> ---
!

I just discovered that when the server sends you </stream:stream> unexpectedly,
the application is still expected to call wocky_porter_close_async(). Seems
pretty silly. As far as I can tell, apps need to listen for remote-closed and
remote-error, and when those signals are emitted, call
wocky_porter_close_async(), but only if they haven't already locally closed the
connection (well, they could call it in that situation too but then it will
fail).

I suppose the client does still need to have some way to know when all its
queued stanzas have been sent, and having to call _close_async() does provide
that. Still feels awkward.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.