[Bug 61302] New: Connector: either support multiple uses, or guard against them reliably

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=61302

          Priority: medium
            Bug ID: 61302
          Assignee: telepathy-bugs at lists.freedesktop.org
           Summary: Connector: either support multiple uses, or guard
                    against them reliably
        QA Contact: telepathy-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: will.thompson at collabora.co.uk
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: General
           Product: Wocky

I tried to re-use a WockyConnector to reconnect after my successful connection
was later disconnected. Initially wocky_connector_connect_async() failed
immediately because priv->result was non-NULL, but I noticed that most (but not
all!) code paths end up setting priv->result back to NULL. So I made it
consistent http://cgit.freedesktop.org/wocky/commit/?id=e77ed03f87 and now it
crashes later:

tcp_srv_connected: wocky-connector.c:941: SRV connection succeeded
**
wocky:ERROR:wocky-connector.c:1073:maybe_old_ssl: assertion failed: (priv->conn
== NULL)

which is to say: priv->conn, which is the WockyXmppConnection, is never set to
NULL once the connection is established.

I think it would be useful to be able to re-use the same connector. A start on
fixing this would be to make the WockyXmppConnection (and full JID and session
id) be the GSimpleAsyncResult's op_res_gpointer (probably fixing bug 35351 in
passing).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.