[Bug 52011] TpBaseContactList announces Group channels twice

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=52011

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Created attachment 72438
  --> https://bugs.freedesktop.org/attachment.cgi?id=72438&action=edit
tp_base_contact_list_set_list_received: don't re-announce groups

We already announced each group from tp_base_contact_list_groups_created
a few lines ago; we don't need to do it again.

Ideally we'd add each channel's members before announcing the
channel itself, so that the channel is created "fully-formed"; but
we've never actually done that, and keeping the first NewChannels
instead of the second seems less likely to break applications.
These channels are only for legacy code anyway: any modern client
should be using the ContactGroups interface.

---

Here's my suggestion for how to fix this. Thoughts?

I've verified with dbus-monitor that test-contact-lists creates each group
once; currently adding a regression test, just to make sure.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.