[Bug 14540] Names interface - Aliasing replacement with separate nickname, local alias etc.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=14540

--- Comment #35 from Xavier Claessens <xclaesse at gmail.com> ---
Thanks for the review, I'll check point by point tomorrow.

A few points, though:

1) I would like to get this merged without any local cache, to not delay for
another 10months. I guess this means that gabble will have to keep is hack
(storing nickname in roster) for now. That means that
implicit_request_nickname() will have to be no-op in gabble, in a way or
another (adding a flag probably, as you suggested).

2) tp_dbus_properties_mixin_set_async() would be great to have, but I would say
it's not blocker to merge this. Current implementation is good enough for now,
ok?

3) About tp_names_mixin_init(): I had the idea of adding a TpNamesMixinPrivate*
in TpBaseConnectionPrivate struct. This wast 64bits per connection on CM that
don't have aliases (big deal...) and simplify all those offset/quark weirdness.
Like that I can just have:

tp_names_mixin_init(TpBaseConnection *self)
{
  self->priv->names_mixin = g_slice_new0();
  self->priv->names_mixin->foo = NULL;
}

tp_names_mixin_finalize(TpBaseConnection *self)
{
  g_slice_free(self->priv->names_mixin);
  self->priv->names_mixin = NULL;
}

TpBaseConnection::finalize()
{
  g_assert(self->priv->names_mixin == NULL);
}

That way we have perfectly introspectable mixins, I think.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.