[Bug 57739] AccountsModel does not list Salut contacts on load

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=57739

--- Comment #4 from George Kiagiadakis <kiagiadakis.george at gmail.com> ---
I *think* this is the well-known problem that factories do not have optional
features. If one feature fails to become ready, then the whole operation fails.

Here the Connection is trying to become ready, creating and populating the
ContactManager in the process. However, because salut does not implement
contact list groups, Connection::FeatureRosterGroups fails and the whole object
remains in a broken state. This patch is only a workaround that fixes
ContactManager's state and is probably part of the solution, but not the whole
solution.

I am not very willing to merge it as it is, given that it complicates even more
the already highly complex roster introspection monster... At least, not
without a proving unit test, which I am sure will make other problems appear
and will force us to effectively make Connection::FeatureRosterGroups
"optional" (which is a completely sane thing to do btw, I am all for it).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.