[Bug 40393] No change notification on Account.Interface.Addressing.URISchemes

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=40393

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|r?                          |r+ with trivial changes
           Assignee|telepathy-bugs at lists.freede |guillaume.desmottes at collabo
                   |sktop.org                   |ra.co.uk
           Keywords|                            |patch

--- Comment #9 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
> + g_object_get (test->account, "uri-schemes", &tmp, NULL);

Whitespace nitpicking: I'd prefer the "linked pairs" pattern:

    g_object_get (test->account,
        "uri-schemes", &tmp,
        NULL);

It would be nice if the doc-comment for the property said "notify::uri-schemes
cannot be relied on if the Account Manager is Mission Control version 5.12 or
older", or something.

This all looks basically good, just some minor nitpicking in each affected
project.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.