[Bug 14540] Names interface - Aliasing replacement with separate nickname, local alias etc.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=14540

--- Comment #46 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #45)

Branch updated.

> http://cgit.freedesktop.org/~smcv/telepathy-glib/commit/
> ?h=names&id=8a6535c1c238108fc8173e2337ca0c7d000d32e4 --> "This the
> #TpContact:local-alias," missing a verb.
> 
> http://cgit.freedesktop.org/~smcv/telepathy-glib/commit/
> ?h=names&id=f0e8ae7326411f4992be79d7da11b2c0bf600819 --> this is from
> another commit:
> - tp_names_mixin_one_nickname_changed (base, data->contact, nickname);
> 
> http://cgit.freedesktop.org/~smcv/telepathy-glib/commit/
> ?h=names&id=414118702d96a042848625552ef6b8b2a168ef6e --> you can use
> self_handle var in the tp_names_mixin_one_nickname_changed() call.

Fixed in "fixup!" commits. The second one is reinstated later in the patch
series, at the right place.

> http://cgit.freedesktop.org/~smcv/telepathy-glib/commit/
> ?h=names&id=156d18599a9b56abe575eb4076e970ba34aa2860 --> adding a new file
> for that seems overkill, why not keep that with the other names tests? otoh
> tests/dbus/contacts.c is already huge... maybe move everything to a new
> tests/dbus/names.c file?

I renamed self-names.c to names.c and moved test_names() there, with a bit of
refactoring to not rely on infrastructure from the regression tests for
obsolete TpContact code paths.

The refactoring is in "test_names: disentangle from TpContact old-code-path
tests a bit" and prior commits. The commit "Move test_names from test-contacts
to test-names" just moves the function as-is, and makes some struct member
names match (async_result -> result, base_connection -> base_conn).

I think this is in a state where we can usefully try porting CMs. I'll do
Salut, you do Haze, and whoever finishes first can start on Gabble?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.