[Bug 59162] New: fix post-0.18 deprecations (and test/fix broken-by-inspection service point code in the process).

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=59162

          Priority: medium
            Bug ID: 59162
          Assignee: telepathy-bugs at lists.freedesktop.org
           Summary: fix post-0.18 deprecations (and test/fix
                    broken-by-inspection service point code in the
                    process).
        QA Contact: telepathy-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: will.thompson at collabora.co.uk
               URL: http://cgit.collabora.com/git/user/wjt/telepathy-missi
                    on-control/log/?h=post-0.18-deprecations
          Hardware: Other
            Status: NEW
           Version: git master
         Component: mission-control
           Product: Telepathy

_mcd_connection_set_tp_connection() uses tp_connection_new() whereas it should
allegedly use tp_simple_client_factory_ensure_connection().

mcd-connection-service-points.c uses tp_connection_request_handles() but it
needs to use tp_connection_dup_contact_by_id_async() which is singular so we
need to call it n times and then coalesce the results and blah blah blah I lost
the will to live. Relatedly, this code has no tests, and by two minutes of
inspection will g_critical() if
http://telepathy.freedesktop.org/spec/Connection_Interface_Service_Point.html#Property:KnownServicePoints
contains more than one Emergency service point:

• parse_services_list() will call _mcd_connection_clear_emergency_data() (which
frees and NULLS priv->emergency.handles);
• then call tp_connection_request_handles() more than once;
• so service_handles_fetched_cb() will be called more than once;
• it calls _mcd_connection_take_emergency_handles() which criticals if
priv->emergency.handles is non-NULL, then sets priv->emergency.handles to the
new set of handles.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.