[Bug 55391] stop MC using things deprecated in 0.20

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55391

--- Comment #43 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #20)
> _mcd_channel_depart: use tp_channel_leave_async if  it's a Group

This and Bug #55392 are now:

http://cgit.freedesktop.org/~smcv/telepathy-mission-control/log/?h=leave-via-newer-api-55391

Xavier reviewed that patch and objected, but I objected to his objection:

(In reply to comment #33)
> (In reply to comment #30)
> > I think it is handler's responsability to do clean group leave. If MC has to
> > close the channel, it can be an abrupt Close(), no?
> 
> In general I would agree with you ... However ...

Anyone have an opinion either way?

> You could reasonably argue that now that we have Chan.T.Call, which doesn't
> (ab)use Group for call-ending, nobody should actually be using
> mcp_dispatch_operation_leave_channels() any more; perhaps we should
> deprecate it, and remove it in next.

Xavier suggests having MC never do RemoveMembers, but I think not changing the
functionality of mcp_dispatch_operation_leave_channels is more important;
perhaps this deprecation is a reasonable compromise?

See also Bug #59162 in which wjt also wants to get rid of deprecated things.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.