[Bug 59165] g_type_init is deprecated from GLib 2.35.1

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jan 9 14:07:34 CET 2013


https://bugs.freedesktop.org/show_bug.cgi?id=59165

--- Comment #8 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 72717
  --> https://bugs.freedesktop.org/attachment.cgi?id=72717
Include config.h to silence deprecation warnings from g_type_init

Review of attachment 72717:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=59165&attachment=72717)
-----------------------------------------------------------------

::: src/test-api.c
@@ +19,4 @@
>   */
>  
>  
> +#include "config.h"

Including config.h as the first thing in every .c file is fine, yes. A better
commit message would be "Include config.h as the first thing in every .c file"
\n\n "This is Autoconf best-practice, and ensures that the GLib and Telepathy
version-selection macros defined by configure.ac work as intended."

::: tests/dbus/test-tpl-log-iter-pidgin.c
@@ +3,4 @@
>  #include "lib/simple-account.h"
>  #include "lib/util.h"
>  
> +#include "telepathy-logger/debug-internal.h"

Why? No reason appears in the commit message.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list