[Bug 14540] Names interface - Aliasing replacement with separate nickname, local alias etc.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=14540

--- Comment #50 from Xavier Claessens <xclaesse at gmail.com> ---
http://cgit.freedesktop.org/~smcv/telepathy-glib/tree/tests/dbus/names.c?h=names&id=e55d7bc56c4af7e80d9be785596844255de7875d
--> I was doing the same for avatars, I changed ADD macro to do the 3
g_test_add() instead of repeating them. Dunno if you find that better :-)

http://cgit.freedesktop.org/~smcv/telepathy-glib/commit/?h=names&id=29766a5cfc785bc314b40ec87196e6b78bc0b68a
--> you can give NULL callback to g_simple_async_report_error_in_idle(). Early
return saves a bit of work, but we don't do it usually... Don't really matters
of you prefer like that :-)

http://cgit.freedesktop.org/~smcv/telepathy-glib/commit/?h=names&id=57eaa0241be6ad60ca2a818cb120e4a8243a99ea
--> 
+ g_value_set_string (value,
+ iface->dup_nickname (conn,
+ tp_base_connection_get_self_handle (conn)));
--> should be g_value_take_string()

+ str = iface->dup_nickname (base, contact);
+
+ if (!tp_str_empty (str))
--> you should free str in the case it is g_strdup(""); or is that a forbidden
return value for dup_nickname? Same for dup_local_alias() later in the patch.

tp_names_mixin_nicknames_changed: Maybe I've misunderstood something, but if
nickname != legacy_alias then you don't have to include that contact in the
array. Also why did you remove the check if the array is empty, we could still
have empty array here and avoid useless signals, no?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.