[Bug 14540] Names interface - Aliasing replacement with separate nickname, local alias etc.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=14540

--- Comment #53 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #52)
> For simplicity, the code does not currently detect the case where
> 
>     local_alias = empty
>     nickname = "dave at example.com"
>     identifier = "dave at example.com"
>     =>
>     legacy alias = "dave at example.com"
> 
> and we change nickname to empty, which has no practical effect

In fact, I don't think it *can* detect this case, because by the time we enter
this function, we have already forgotten what the old nickname was.

This is the same reason why this function can't filter out no-op changes from
NicknameUpdated: dup_nickname() already returns the new version.

I think that way round (dup_nickname() already returns the new version by the
time this function is called) seems less astonishing (and far easier to
implement!) than documenting that dup_nickname() must still return the old
version until just after the change-notification call.

Also, if people mis-implement this and have dup_nickname() still returning the
old version, I don't think we actually notice; whereas if we relied on
dup_nickname() still returning the old version but someone mis-implemented it
to return the new version, we'd never emit a change notification.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.