[Bug 66459] Integrate new accounts-sso support into mission-control

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=66459

Xavier Claessens <xclaesse at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xclaesse at gmail.com

--- Comment #2 from Xavier Claessens <xclaesse at gmail.com> ---
The patch does not apply on MC master here. You should use "git format-patch" 
or link to the branch here (you can host on github for example).

>From a quick read of the patch:

1) you don't need signon dependency

2) Would be nice to remove "uoa", "ubuntu" and "empathy" words from the code.
Previous plugin seems to be called "libaccounts-sso", I think "sso" does not
mean much, so I would call the new plugin just "libaccounts".

3) EmpathyWebcredentialsMonitor is problematic, it uses an ubuntu specific dbus
service. As I understand, its only purpose is to tell MC to retry connecting
when a previous auth failure got resolved (like user re-typing his pwd, or
grant permission on google app, etc). I have to admit I'm not sure how to fix
this, and it seems GOA plugin does not do anything similar (so I suppose it
just doesn't work there).  I see various solutions, but none satisfy me
completely:
  a) keep it out of scope from MC plugin, "something" else will have to tell MC
to reconnect.
  b) standardize a freedesktop spec for that iface.
  c) Add a "auth-failure" boolean property on AgAccount and make change
notification through account's db.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.